[Kde-pim] Review Request: newresultpage.cpp:109: warning: unused parameter 'msg'

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2240/#review3483
-----------------------------------------------------------


Same #warning issue as with the other unused parameter warning review requests.

Here it looks like the progress bar simply doesn't display the message, and therefore the Q_UNUSED is ok.


/trunk/KDE/kdepim/kleopatra/crypto/gui/newresultpage.cpp
<http://reviewboard.kde.org/r/2240/#comment2789>

    Please don't add these comments if you haven't if the function is empty for a reason, it could be intenden.



/trunk/KDE/kdepim/kleopatra/crypto/gui/newresultpage.cpp
<http://reviewboard.kde.org/r/2240/#comment2788>

    The empty destructor could be removed instead.


- Thomas


On 2009-11-20 18:01:24, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2240/
> -----------------------------------------------------------
> 
> (Updated 2009-11-20 18:01:24)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/kleopatra/crypto/gui/newresultpage.cpp:109: warning: unused parameter 'msg'
> 
> my proposal: add Q_UNUSED( )
> see: newresultpage-gm-99.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/crypto/gui/newresultpage.cpp 1047639 
> 
> Diff: http://reviewboard.kde.org/r/2240/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/