[Kde-pim] Review Request: KMReaderWin::Message() cleanup

Allen Winter winter at kde.org
Sat Dec 12 20:15:02 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2363/
-----------------------------------------------------------

Review request for KDE PIM and Thomas McGuire.


Summary
-------

Here's a cleanup of KMReaderWin::Message().  The code was incomprehensible and way overly complicated, I think.  But I would love others to review before I commit.  It may have also been the culprit in some crashes.


Diffs
-----

  /trunk/KDE/kdepim/kmail/kmmessage.h 1061664 
  /trunk/KDE/kdepim/kmail/kmreaderwin.h 1061664 
  /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1061664 

Diff: http://reviewboard.kde.org/r/2363/diff


Testing
-------

Just using it.


Thanks,

Allen

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list