[Kde-pim] Review Request: KMReaderWin::Message() cleanup

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2363/#review3409
-----------------------------------------------------------


How do your changes relate to the work in the akonadi-ports branch? If the changes will be obsolete with the Akonadi port then we should not risk a regression in the last pre-Akonadi KMail unless the changes fix a major bug. IMHO the pre-Akonadi code base of KMail should be considered as frozen with respect to all changes that do not fix a software defect.


- Ingo


On 2009-12-12 20:15:01, Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2363/
> -----------------------------------------------------------
> 
> (Updated 2009-12-12 20:15:01)
> 
> 
> Review request for KDE PIM and Thomas McGuire.
> 
> 
> Summary
> -------
> 
> Here's a cleanup of KMReaderWin::Message().  The code was incomprehensible and way overly complicated, I think.  But I would love others to review before I commit.  It may have also been the culprit in some crashes.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmmessage.h 1061664 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1061664 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1061664 
> 
> Diff: http://reviewboard.kde.org/r/2363/diff
> 
> 
> Testing
> -------
> 
> Just using it.
> 
> 
> Thanks,
> 
> Allen
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/