[Kde-pim] KTimeChooser time editing widget

[Thomas McGuire]

Hi,

On Thursday 13 August 2009 01:21:01 you wrote:
> a while ago I took up Allen's request to make KPIM::KTimeEdit ready for
> kdelibs. I named the new one KTimeChooser as it seemed more appropriate.
>  The current outcome can be found here and needs a current trunk to compile
>  (r1006747, one week ago):
> http://websvn.kde.org/trunk/playground/libs/ui/ktimewidgets
> 
> Please check if you're happy with it.

I had a quick look at the headers only:

- The private methods in KTimeEdit and the other classes should probably be in 
  the private class
- KTimeChooser should inherit KComboBox, not QComboBox
- I would say remove the TimeFormatOptions option from the KTimeValidator   
  constructor, as you have a setter for that, see
  http://doc.trolltech.com/qq/qq13-apis.html#theconveniencetrap

All in all, looks very clean. Thanks for your efforts on this, one class less 
in libkdepim :)

Regards,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090813/33e1dc6c/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/