[Kde-pim] Review Request: make the maildir filename separator configurable

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1354/#review2098
-----------------------------------------------------------


I object to this patch.

At least, when reading maildir folders we need to support ':' and '!' (if '!' is configured to be used) because if we access a maildir folder that it not controlled by us (e.g. the system's mail spool which can be a maildir folder) then ':' will have to be used. Instead of using a fixed separator (either ':' or '!') we should dynamically adapt to the situation. If ':' cannot be used for a folder because the folder resides on a filesystem that does not allow ':' to be used in filenames then we should automatically fallback to '!'. The separator that is used for a folder should be stored per folder together with the other per-folder options.

- Ingo


On 2009-08-18 21:15:06, Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1354/
> -----------------------------------------------------------
> 
> (Updated 2009-08-18 21:15:06)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> On NFS and FAT filesystems ":" is not an allowed character, which is used now as part of maildir files.
> The current code does it hardcoded: for Windows == "!", others ":"
> This patch makes this character configurable (without GUI!).
> 
> 
> This addresses bug 55339.
>     https://bugs.kde.org/show_bug.cgi?id=55339
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/kmfoldermaildir.cpp 1013113 
>   trunk/KDE/kdepim/kmail/kmkernel.h 1013113 
>   trunk/KDE/kdepim/kmail/kmkernel.cpp 1013113 
> 
> Diff: http://reviewboard.kde.org/r/1354/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/