[Kde-pim] Review Request: make the maildir filename separator configurable

[Martin Koller]

Hi Ingo,

On Thursday 20 August 2009, Ingo Klöcker wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1354/#review2098
> -----------------------------------------------------------
> 
> 
> I object to this patch.
> 
> At least, when reading maildir folders we need to support ':' and '!' (if
>  '!' is configured to be used) because if we access a maildir folder that
>  it not controlled by us (e.g. the system's mail spool which can be a
>  maildir folder) then ':' will have to be used. Instead of using a fixed
>  separator (either ':' or '!') we should dynamically adapt to the
>  situation. If ':' cannot be used for a folder because the folder resides
>  on a filesystem that does not allow ':' to be used in filenames then we
>  should automatically fallback to '!'. The separator that is used for a
>  folder should be stored per folder together with the other per-folder
>  options.

Your points might be valid. However: the patch does in principle implement 
what was already done hardcoded before. The only thing it changes, is the 
possibility to change the hardcoded value.
And in the light of the switch to the new akonadi maildir handling, which 
currently does not have this problem, as it does not use the maildir schema 
for the filenames, I think it's really not worth the effort.

-- 
Best regards/Schöne Grüße

Martin    ()  ascii ribbon campaign - against html mail 
          /\                        - against microsoft attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20090820/62d91041/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/