[Kde-pim] Using TimeZones in KDEPIM

Allen Winter winter at kde.org
Tue Apr 21 18:07:01 BST 2009


On Tuesday 21 April 2009 12:50:29 pm David Jarvie wrote:
> On Tuesday 21 April 2009 17:04, Allen Winter wrote:
> > Howdy,
> >
> > Till and I were discussing timezones this morning and it became clear to
> > us that we no longer need to use KOrganizer as the "timezone setting app"
> > for all of KDEPIM -- we should be using the KDE system timezone for that
> > now.
> >
> > So here's a proposed plan that we think will solve this.
> > Let us know what you think about it.
> >
> > The Plan:
> > 1) Ignore the TimeZoneId setting in korganizerrc
> >    a) change KPimPrefs::timeSpec() to only look for your system timezone.
> >        (currently it looks for korganizerrc's TimeZoneId value first, then
> >         the system timezone)
> >    b) change the timezone pref in korganizer (Settings->Time&Date)
> >         to modify the system timezone -- and no longer write TimeZoneId.
> >         with the appropriate to "do you really want to change the system
> >         timezone" confirmation dialog.
> > 2) Ensure all KDEPIM apps call KPimPrefs::timeSpec() when they want to
> > know
> >     the timezone.
> 
> I'm not sure I really understand what you're proposing. AFAICS, what you
> are saying is that the system time zone should always be used as the main
> setting for PIM apps, and if a different time zone is selected in
> KOrganizer's settings, that should be set as the new system time zone
> (which would need the root password to change).

Yep.

> If that's correct, then I don't see the need to use KPimPrefs::timeSpec() at all,
> since it will just return the system time zone which could more transparently be
> fetched by KSystemTimeZones::local().
> 
That's true.  We could replace KPimPrefs::timeSpec() with KSystemTimeZones::local().
I was just taking the path of less-work. 

Certainly we could change 2) to:
Ensure all KDEPIM apps call KSystemTimeZones::local() when they want to know the timezone.


-- 
Allen Winter | allen at kdab.net | Software Engineer
KDAB (USA), LLC, a KDAB Group company
Tel. USA +1-866-777-KDAB(5322), Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-independent software solutions
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list