[Kde-pim] KDE 3.5.final?

[Ingo Klöcker]

On Thursday 04 September 2008, Allen Winter wrote:
> On Wednesday 03 September 2008 17:01:43 Giovanni Venturi wrote:
> > Alle martedì 02 settembre 2008, Allen Winter ha scritto:
> > > On Tuesday 02 September 2008 16:57:30 Giovanni Venturi wrote:
> > > > Alle domenica 31 agosto 2008, Thomas McGuire ha scritto:
> > > > > For the record: I completely agree with Allen here, let's
> > > > > stop committing to that branch.
> > > > > As Allen already mentioned, nobody tested it and some commits
> > > > > caused regressions like bug 169991.
> > > >
> > > > And like this:
> > > > http://bugs.kde.org/show_bug.cgi?id=168544
> > > >
> > > > That has to be fixed IMHO. You can froze the branch for new
> > > > features, but not from "heavy" bug that should be fixed.
> > >
> > > I'm not against obvious fixes of grave regressions.
> > > If someone posts a patch here and Ingo (or someone very KMail
> > > smart) can give the go-ahead, then I will allow the patch and I
> > > will also contact the packagers about it.
> > >
> > > -Allen
> >
> > Here the patch for the inbox hidden: from the proposed code for
> > kde4. Can I commit into 3.5 branch? I tested and the inbox appear
> > again. Giovanni
>
> If Ingo or Thomas or any other KMail expert approves the patch
> then I will commit it and tell the packagers to patch their distros.

Frankly, the following piece of code looks pretty strange to me.

+    KMFolder *folder = account->folder();               // init 
folder's account list
+    if ( folder && !folder->hasAccounts() )
+      account->setFolder( folder, true );

Why set the folder of an account to the folder it is already set to? The 
code looks very fragile because it seems to make assumptions about the 
internals of other classes. I'll need more time to investigate whether 
this really is the best way to fix the problem.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080904/0be0fb26/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/