[Kde-pim] i18n bugs in kaddressbook

[Kevin Krammer]

Hi Burkhard,

On Sunday 21 September 2008, Burkhard Lück wrote:
> Am Freitag 19 September 2008 17:29:39 schrieb Burkhard Lück:
> > Hi,
> >
> > I have a lot of untranslated messages in kaddressbook.
>
> All (generated) entries in mFieldCombo in
> kdepim/kaddressbook/incsearchwidget.cpp are untranslatable:
>
> In kde3 I found all all these messages in kdelibs.po, they were generated
> with this line in Makefile.am.in:
> cd kabc/scripts && perl ./makeaddressee
>
> This line is no longer in the Messages.sh for kdelibs4.pot, because
> kabc/scripts has been moved to kdepimlibs.
> But in kdepimlibs this script is never executed in any Messages.sh, that's
> why the messages are untranslatable.

Ah, so basically a porting mistake caused by the module reorganisation. Thanks 
for tracking it down.

> My question is, which applications in kdepim uses these messages
> like "Business Address City" etc. and into which message catalog they have
> to be extracted?

These strings are meant to be uses as labels/hints for application displaying 
these fields or allowing their input, so they are most likely used by more 
than just KAddressBook.

> I sugest to extracr them to kabc.pot and include this message catalog into
> applications like kaddressbook, which need these translations.

Agreed.

> With this patch I get all missing messages:
> kdestable at rebutia:~/svn/kdepimlibs/kabc$ svn diff .
> Index: Messages.sh
> ===================================================================
> --- Messages.sh (Revision 863014)
> +++ Messages.sh (Arbeitskopie)
> @@ -1,2 +1,3 @@
>  #! /usr/bin/env bash
> +#cd scripts && perl ./makeaddressee
>  $XGETTEXT *.cpp -o $podir/kabc.pot

Are you sure the # in front of the "cd scripts" is correct?

> But with this patch I also have two new generated files:
> kdestable at rebutia:~/svn/kdepimlibs/kabc$ svn st addressee.h addressee.cpp
> I      addressee.h
> I      addressee.cpp
>
> Should they be removed at the end of Messages.sh?

Hmm, assuming that in-source-tree builds are still supported somebody might do 
that and need these two files for the normal build.

Cheers,
Kevin

-- 
Kevin Krammer, KDE developer, xdg-utils developer
KDE user support, developer mentoring
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080921/b8b744f5/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/