[Kde-pim] patch to use the emoticonslib in linklocator

[Tom Albers]

Op dinsdag 13 mei 2008 01:31 schreef u:
> Hi,
> I've made a patch to use the emoticons lib inside linklocator, the
> emoticons library is currently in kdereview and it will be moved to
> kdelibs before the hard feature freeze
> 
> Carlo

Hi Carlo,

Thanks for the patch. It looks good to me, except for a two concerns.

1.
You moved the "if ( flags & ReplaceSmileys ) {" 20 lines down, why is that (did not pull up the actual code).

2.
In the pimemoticons.kcfg there are a lot of commented out emoticons. Did you verify that none of them becomes active again with the new library?

3.
Don't forget to remove -lkemoticons if needed.

4.
Please check coding style, I at least spotted a lack of space after a (

Overall: nice work and thank you. Can you commit it after the move to kdelibs? If that is before beta 1, please make sure this patch goes in as well before beta 1, so we can have some testing.

Best.

Toma
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/