[Kde-pim] [patch] handling of static data in akonadi and mailtransport

[Thomas McGuire]

Hi,

On Tuesday 20 May 2008, Jarosław Staniek wrote:
> the patch

No need for static void cleanup(), you can simplify that by writing 
qAddPostRoutine( sSelf.destroy ).
I'm not sure if the qAddPostRoutine() hack is needed (the difference is only 
that the object is destroyed when QCoreApplication is deleted, not when the 
library unloads), but it is probably better to be safe than sorry.
Other than that and Ingo's comments, the mailtransport changes seem fine, 
although I would use class SlavePool instead of struct SlavePool, since a 
struct with functions is a bit weird (although you already removed much 
weirdness from mailtransport:)

Regards,
Thomas


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080520/a1bc23eb/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/