[Kde-pim] [patch] handling of static data in akonadi and mailtransport

[Thomas McGuire]

Hi,

On Tuesday 20 May 2008, Tom Albers wrote:
> Op dinsdag 20 mei 2008 19:44 schreef u:
> > > Because it's a static block of data in a shared library, not app. If
> > > you use K_GLOBAL_STATIC, you know you'll have one global instance
> > > with initialized members.
> > > See http://www.kdedevelopers.org/node/2889
> >
> > Apart from this the static was shared by all instances of SocketPrivate.
> > I don't think this is what was intended unless SocketPrivate was a
> > singleton. But even if it was a singleton then one should still have
> > used a member variable for buffering the incoming data.
> >
> > IOW, unless I'm missing something then using a static local variable was
> > plain wrong.
>
> Well, I still don't understand the difference with a global member in that
> case. Both ways it can expose the wrong data, right?
The static variable is shared by all instances of the socket class, whereas 
each instance has its own member variable. I can ownly imagine this leads to 
big problems when using multiple sockets at the same time...

Regards,
Thomas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080520/a0ecc8b5/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/