[Kde-pim] [patch] fix improper seperator in ACL lists

David Faure faure at kde.org
Wed May 7 11:21:08 BST 2008


On Tuesday 06 May 2008, Carsten Wolff wrote:
> (please reply to all, I'm not subscribed)
> 
> Hi!
> 
> At the Debian groupware meeting last month, Wilfried from citadel.org 
> mentioned to me the fact, that Citadel would work well as a Kolab1 server for 
> Kontact, if it wasn't for messed up ACL-lists in KMail when userids with 
> spaces in them are involved. Attached is a patch for KDEPIM3.5.9 to fix that.
> 
> Whoever wrote the ACL-Code in kio_imap4, wrote in his code-comment, that he 
> thought spaces weren't allowed in userids and so he used it as a seperator. 

302877     dfaure     // limits me to a string instead of a stringlist. I'm using space as separator,
Whoops ;-)

> It seems to me though, that Citadel is right to allow spaces in userids, 
> because I can't find anything against that in rfc3501.txt.
> 
> The RFC states double-quotes are a forbidden character though, so I used it in 
> my patch instead.

OK.

> I'm not sure to commit though, because I don't know if any app besides KMail 
> uses kio_imap4 and I don't want to break any such program. What do you think? 
> Is it safe to commit?

Tom: mailody doesn't use this, right?
Otherwise I don't think anything else uses the ACL stuff from kio_imap4.
Please commit -- after adjusting the comment in imap4.cc ;-))

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list