[Kde-pim] [patch] Minor optimisation for kdepimlibs/mailtransport
Brad Hards
bradh at frogmouth.net
Wed May 7 12:54:30 BST 2008
Is this change OK? It doesn't seem to make much sense to construct the QBuffer
just to do a readAll(), when you already have the byte array
Brad
Index: mailtransport/sendmailjob.cpp
===================================================================
--- mailtransport/sendmailjob.cpp (revision 805010)
+++ mailtransport/sendmailjob.cpp (working copy)
@@ -72,7 +72,7 @@
setErrorText( i18n( "Failed to execute mailer program %1",
transport()->host() ) );
emitResult();
} else {
- d->process->write( buffer()->readAll() );
+ d->process->write( data() );
d->process->closeWriteChannel();
}
}
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list