[Kde-pim] Text formatting stripped from text pasted into kmail composer.

Ingo Klöcker kloecker at kde.org
Sun Mar 16 22:31:06 GMT 2008


On Saturday 15 March 2008, Stephen Kelly wrote:
> Hi,
>
> Thanks for that fix and for reviewing the patch.
>
> It's not quite ready to go in. Don't worry anyway, it won't be
> forgotten.
>
[snip]
>
> In response to Ingo's mail I've also
>   - Tried changing 'Link' to 'ki18nc("A Url link.", "Link")', but got
>     compile error:
>         error: no matching function for call
>         to ‘KAction::setIconText(KLocalizedString)
>   - Fixed the (C) issue. It looks like this needs to be changed all
> over kde - Renamed the methods.
>   - Changed the ctor. This made it neccessary to change how focus
> shifts around the dialog.
>   - Fixed whitespace issue
>   - Made the dialog non-modal.
>   - Removed the margin and spacing settings.
>   - Left the handling of an empty text field up to the developer
> using the dialog. In this case I implemented Ingo's suggestion.
>   - Didn't use UI file. Might do so before committing.
>
> Thanks for the comments Ingo.
>
> I also don't like the minimum width thing, but I wasn't sure what to
> do about it. I didn't want people to need to have to resize the
> dialog each time they use it.

I suggest saving the last used size and restoring it on next usage.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080316/8db01880/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list