[Kde-pim] [patch] kdepimlibs/mailtransport: destroy TransportManager using qAddPostRoutine

Jaroslaw Staniek js at iidea.pl
Wed Jun 18 11:03:09 BST 2008


Tom Albers said the following, On 2008-06-18 11:45:
> As beta 2 Op woensdag 18 juni 2008 11:37 schreef u:
>> (for review; enterprise4 branch)
>>
>> Destroy TransportManager using qAddPostRoutine, not K_GLOBAL_STATIC.
>> This avoids crash on application's quit: destroying through K_GLOBAL_STATIC is 
>> too late for this object.
>>
> I don't see a crash on applications quit.

Perhaps it can be reproduced only for builds where values like 0xdddddddd are 
assigned to pointers on destruction of memory areas. It would be possible to 
find a warning in valgrind too. For runtimes where pointers to destroyed 
memory are left untouched, you indeed would not see the crash.

> As this is too late for beta2, which is the last beta, I ask to wait with this patch for KDE 4.2.

I'll commit to enterprise4 then.

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list