[Kde-pim] [patch] Printing emails

[Till Adam]

On Tuesday 08 July 2008 00:14:57 Ingo Klöcker wrote:
> On Monday 07 July 2008, Jaroslaw Staniek wrote:
> > Possible fix for [1] (Windows).
> > For review.
> >
> > The code (before patching) works on Linux (?) only by accident, I
> > guess (probably thanks to different strategy of handling QTimers with
> > 0 delay [2]).
> >
> > Explanation: KMReaderWin::printMsg() _can_ be executed before the
> > timer handling slotWriteNextHtmlChunk() finishes. And it is, on
> > Windows. Another place where usign timers looks unfortunate..
> >
> > [1] http://intevation.de/roundup/kolab/issue2647
> > [2] mHtmlTimer.start( 0 );
>
> The correct fix would be making sure that printMsg() is not called
> before writting the HTML is finished (probably by introducing a new
> signal and listening to it). I'm not sure your patch is a good fix
> since it is clearly against the intent of KHtmlPartHtmlWriter to write
> the full queue synchronously to the HTML part. Since Marc wrote this
> class I hope he will comment on this.


Marc is on vacation, atm. I agree with your assessment, though, Ingo.


-- 
Till Adam
KDAB - platform independent software services
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/