[Kde-pim] [patch] kmail deps, round 2
Jarosław Staniek
js at iidea.pl
Fri Jan 18 12:08:01 GMT 2008
Allen
You've pinged me on the KMAIL_SUPPORTED patch. It was broken indeed, I've used
${KMAIL_SUPPORTED} now and korganizer is now just fully excluded if
KMAIL_SUPPORTED is false.
The main reason for such a more strict dependency is that the time consumbed
by full build is not small, so would be good to have correct warning about
problem with collecting deps for app like KMail. Without this it is common to
have unresolved symbols as the very last stage of the build process. After
weeks it is not a problem for me and collegues out there to fix that by hand
but once we get new contributors...
You may ask about BUILD_kmail - it is something different - I guess
KMAIL_SUPPORTED has priority over it: if KMail cannot be built,
BUILD_kmail==true means nothing.
Attached the new patch.
One question (not yet answered in the patch) is that perhaps we should make
the variable KMAIL_SUPPORTED dependent on BUILD_kmail - set KMAIL_SUPPORTED to
false if BUILD_kmail is false.
--
regards / pozdrawiam, Jaroslaw Staniek
Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
KDE Libraries for MS Windows (http://windows.kde.org)
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kmail-deps2.patch
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080118/d8cc65d9/attachment.ksh>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list