[Kde-pim] Questionable change to KCal::Period class

[David Jarvie]

On Thursday 28 February 2008 8:20, Kevin Ottens wrote:
> Le Saturday 23 February 2008, David Jarvie a écrit :
>> The commit below alters the kcal Period class in what I think is an
>> undesirable way. It adds summary and location members to the class,
>> which I
>> don't think belong there. What is the relevance of these members to a
>> class
>> which encapsulates a time period?
>
> Indeed, as pointed by Till it was the result of a merge so I don't know
> what
> led to the original decision to put this information there. It seems it
> was
> the easiest solution at that time.
>
> Anyway, here is a patch, I basically splitted Period into Period and
> FreeBusyPeriod (inheriting from Period). That basically forces to
> duplicate a
> couple of methods and ctors in the FreeBusy class in order to keep BC.

The patch looks fine as far as I'm concerned - it's much as I expected it
would be. Thanks.

-- 
David Jarvie.
KAlarm author & maintainer.
http://www.astrojar.org.uk/kalarm

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/