[Kde-pim] Questionable change to KCal::Period class

[Kevin Ottens]

Le Saturday 23 February 2008, David Jarvie a écrit :
> I'm repeating this posting with a different subject line, and top-posting,
> to elicit some response.

Sorry for the delay, got sidetracked on other stuff.

> The commit below alters the kcal Period class in what I think is an
> undesirable way. It adds summary and location members to the class, which I
> don't think belong there. What is the relevance of these members to a class
> which encapsulates a time period?

Indeed, as pointed by Till it was the result of a merge so I don't know what 
led to the original decision to put this information there. It seems it was 
the easiest solution at that time.

Anyway, here is a patch, I basically splitted Period into Period and 
FreeBusyPeriod (inheriting from Period). That basically forces to duplicate a 
couple of methods and ctors in the FreeBusy class in order to keep BC.

I'm not exactly sure I like busyPeriods() vs fullBusyPeriods(), but I couldn't 
come up with a better name while keeping BC.

Comments welcome.

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdepim_freebusy_period.patch
Type: text/x-diff
Size: 15241 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080228/a6b826ba/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080228/a6b826ba/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/