[Kde-pim] [patch] Windows port of Maildir and some simplified code

[Thomas McGuire]

Hi,

On Thursday 07 February 2008, Jarosław Staniek wrote:
> For review:
>
> - process of simplifying/Qt-ifying the code started:
>     FolderStorage::canAccess() now returns bool,
>     and thus also the same method in KMFolderSearch, KMFolderMaildir,
>     KMFolderMbox, KMFolder

Good, much saner now.

> - Maildir filenames: use '!' character separator instead of ':' for windows
>     (KMAIL_MAILDIR_FNAME_SEPARATOR macro),
>     as it is impossible to create a file containing ':' (regardless of the
>     used filesystem - it is a property of the FS API itself)
>
> - KMFolderMaildir::canAccess() use QFileInfo instead of access() - solves
>     problem with undefined
>     X_OK flag on windows and is still enough efficient as there are no
> hundreds of dirs in a maildir
>
> - KMFolderIndex::recreateIndex() now returns bool
>
> - KMFolderDir::reload() simplified

These changes also look fine to me.

Just the usual style nitpicking:
- Stay with 2 spaces, you used 4 spaces in two places: kmnfoldersearch.cpp and 
  in kmmsgbase.cpp (though the later is very inconsistent, but new code should   
  be 2 spaces)
- Please use spaces around parenthesis for new code, for example you should 
  have done that in your kmfolderindex.cpp change. Changing that in the other 
  places you've touched would be nice too, but not so important.

Please commit after making the changes.

Regards,
Thomas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080208/b6f6df25/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/