[Kde-pim] [PATCH] Honour toolbar settings in KMail

Andras Mantia amantia at kde.org
Thu Feb 7 22:01:55 GMT 2008


Hi,

 although such changes I'd usually commit without pre-review, in this 
case the patch reverts a previous commit of our new maintainer, so I 
post it here. :)
 applyMainWindowSettings has a role to read not only the MainWindow 
setting itself, but the settings for its toolbars (icon size, icon/text 
style), statusbar, menubar. If this is called prior to createGUI, the 
settings will be simply ignored. You can easily see this in KMail: even 
if you change the icon style for the main toolbar, it is forgotten on 
next start.
 I doubt that moving it before createGUI really helped in restoring the 
size as it is restoring even now (and it should do like that). Still, I 
don't know what case was broken, so in case you don't agree with me, 
test it and see how it behaves. I tested only as a standalone 
application, not inside Kontact. 

Andras

-- 
 
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmail-toolbar.dif
Type: video/dv
Size: 1097 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080208/a221997d/attachment.dif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080208/a221997d/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list