[Kde-pim] Patch to fix bug 134036

[Shai Berger]

Hi Pimsters,

A couple of months ago I came to this list to mention some BiDi problems in 
KMail trunk, and some solutions to them  that I had. I've been following the 
list since then, and noted the advice that patches posted only in bugzilla 
tend to stay there, but I couldn't find the time to revalidate my patch so I 
could post it here.

But now, I have found the time, so I'm attaching an updated  version of the 
patch against trunk. The horrible regressions are still there, as far as I 
can tell (starting a paragraph in Hebrew does not make it RTL in the editor, 
as it does in 3.5 -- and this is probably a Qt issue), but this patch 
improves the handling of mixed paragraphs. The full details are in 
http://bugs.kde.org/show_bug.cgi?id=134036, but at a sound-byte level, if you 
read this message in kmail, then the next line should appear right-justified 
שלום because it starts with a Hebrew word, and if it had some more hebrew in 
it, its words would be thrown out of order too; the patch improves this by 
guessing when a new line is really a new paragraph (issue can't be solved  
completely because paragraphs are not well-defined in plaintext mail).

Thanks for your good work, and have fun,

	Shai.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmail-bidi.patch
Type: text/x-diff
Size: 3887 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20080426/30efdd52/attachment.patch>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/