[Kde-pim] KDateEdit

[Andreas Hartmetz]

On Saturday 08 September 2007 12:13:12 Tobias Koenig wrote:
> On Fri, Sep 07, 2007 at 08:12:43PM -0400, Allen Winter wrote:
> > Howdy,
>
> Hi Allen,
>
> > Cornelius' and Tobias' KDateEdit widget from libkdepim
> > seems to be copied to a lot of places.  I found copies
> > in playground, digikam, kphotoalbum, etc.
> >
> > Is this widget something we should try to move into kdelibs?
>
> Yes definitely, it is not pim-specific, so kdepimlibs doesn't
> really match IMHO.
>
> But it needs a API review before moving!
>
To me, the public API looks very good (minimal, clear). Extensions can always 
be added...
I would recommend to change the validation part of the API so that it works 
the same way as KKeySequenceWidget - it was changed there for good reasons 
(or so I hope :) ) - have a look at the thread "[PATCH] New signal for 
KKeySequenceWidget" on kde-core-devel, starting August 20th.
If you don't want to read the thread - subclassing to override one function 
bad, signals & slots good :)
setupKeywords() could use some more detailed documentation (keywords - what 
keywords?) and a better name: addKeywords, appendKeywords, setKeywords?, 
whichever fits best.
You should probably replace keywords by predefinedDates (ugh) or something way 
better than predefinedDates.

> Ciao,
> Tobias


_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/