[Kde-pim] Invitation Answer Strings (Was: branches/KDE/3.5/kdepim/kmail)

[Volker Krause]

On Tuesday 22 May 2007 17:22:25 Allen Winter wrote:
> Anyone know if the invitation answer strings below should
> be translatable?

I don't know anything about exchange, but I wouldn't expect it to parse the 
subject of these mails. So I think translating it is fine, that's also what 
is done in non-exchange compat mode.
However, the internal strings (those compared with 'status' below) must not be 
translated.

regards
Volker

> -Allen
>
> ----------  Forwarded Message  ----------
>
> Subject: Re: branches/KDE/3.5/kdepim/kmail
> Date: Tuesday 22 May 2007
> From: Thorsten Staerk <thorsten at staerk.de>
> To: winter at kde.org
>
> On Monday 21 May 2007 01:45:29 Allen Winter wrote:
> > On Tuesday 08 May 2007 4:41:10 pm Thorsten Staerk wrote:
> > > SVN commit 662660 by tstaerk:
> > >
> > > give original style answers about meeting attendance
> > > BUGS:145091
> > >
> > >
> > >  M  +4 -1      callback.cpp
> > >  M  +1 -1      callback.h
> > >
> > >
> > > --- branches/KDE/3.5/kdepim/kmail/callback.cpp #662659:662660
> > > @@ -63,7 +63,10 @@
> > >    KMMessage *msg = new KMMessage;
> > >    msg->initHeader();
> > >    if ( GlobalSettings::self()->exchangeCompatibleInvitations() ) {
> > > -    msg->setSubject( status );
> > > +    if ( status == QString("cancel") ) msg->setSubject(
> > > QString("Declined: %1").arg(subject).replace("Answer: ","") ); +   
> > > else if ( status == QString("tentative") )
> > > msg->setSubject(QString("Tentative: %1").arg(subject).replace("Answer:
> > > ","") ); +    else if ( status == QString("accepted") )
> > > msg->setSubject( QString("Accepted:
> > > %1").arg(subject).replace("Answer: ","") ); +    else msg->setSubject(
> > > subject );
> >
> > I wonder if the QStrings() above should have been i18n() instead?
> > IOW, should these have been translatable strings?
>
> no, I always get these QStrings in english when communicating with
> Exchange. Can someone shed light on the question if there are settings for
> this ?
>
> > I have no idea how the invitation stuff works, but I would think the
> > subjects should be i18n(), right? And should the status variable compares
> > be against QString("cancel|tentative|accepted") or
> > QLatin1String("cancel|tentative|accepted") or
> > i18n("cancel|tentative|accepted")??
> >
> > Too late for 3.5.7, but this needs to be forward ported.
> >
> > -Allen
>
> -------------------------------------------------------


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070524/b443db62/attachment.sig>
-------------- next part --------------
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/