[Kde-pim] Invitation Answer Strings (Was: branches/KDE/3.5/kdepim/kmail)

[Allen Winter]

Anyone know if the invitation answer strings below should
be translatable?  
-Allen

----------  Forwarded Message  ----------

Subject: Re: branches/KDE/3.5/kdepim/kmail
Date: Tuesday 22 May 2007
From: Thorsten Staerk <thorsten at staerk.de>
To: winter at kde.org

On Monday 21 May 2007 01:45:29 Allen Winter wrote:
> On Tuesday 08 May 2007 4:41:10 pm Thorsten Staerk wrote:
> > SVN commit 662660 by tstaerk:
> >
> > give original style answers about meeting attendance
> > BUGS:145091
> >
> >
> >  M  +4 -1      callback.cpp
> >  M  +1 -1      callback.h
> >
> >
> > --- branches/KDE/3.5/kdepim/kmail/callback.cpp #662659:662660
> > @@ -63,7 +63,10 @@
> >    KMMessage *msg = new KMMessage;
> >    msg->initHeader();
> >    if ( GlobalSettings::self()->exchangeCompatibleInvitations() ) {
> > -    msg->setSubject( status );
> > +    if ( status == QString("cancel") ) msg->setSubject(
> > QString("Declined: %1").arg(subject).replace("Answer: ","") ); +    else
> > if ( status == QString("tentative") ) msg->setSubject(QString("Tentative:
> > %1").arg(subject).replace("Answer: ","") ); +    else if ( status ==
> > QString("accepted") ) msg->setSubject( QString("Accepted:
> > %1").arg(subject).replace("Answer: ","") ); +    else msg->setSubject(
> > subject );
>
> I wonder if the QStrings() above should have been i18n() instead?
> IOW, should these have been translatable strings?
no, I always get these QStrings in english when communicating with Exchange. 
Can someone shed light on the question if there are settings for this ?
>
> I have no idea how the invitation stuff works, but I would think the
> subjects should be i18n(), right? And should the status variable compares
> be against QString("cancel|tentative|accepted") or
> QLatin1String("cancel|tentative|accepted") or
> i18n("cancel|tentative|accepted")??
>
> Too late for 3.5.7, but this needs to be forward ported.
>
> -Allen



-------------------------------------------------------

-- 
KDEPIM Developer
I accept PayPal payments to awinterz at earthlink.net
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/