[Kde-pim] KBlog library

[Christian Weilbach]

Am Mittwoch 13 September 2006 schrieb David Jarvie:
> On Wednesday 13 September 2006  4:27, Allen Winter wrote:
> >On Tuesday 12 September 2006 20:54, Christian Weilbach wrote:
> >>Hi,
> >>
> >>I'm sending you a first code for the kblog library in kdepimlibs. I don't
> >> want to submit it right now, since the documentation is not finished yet
> >> and I haven't tested the functionality of the ported code yet. But I
> >> would like to know if there are any problems with it.
> >
> > - David will hurt you ..
>
> Perhaps a slight exaggeration ;-)
>
> > you are using QDateTimes.  Better change over to KDateTimes.
> >   But we can probably address that later too.  We all have a lot of work
> > changing over to KDateTime.
>
> There are not many date/time values in the kblog code, so it won't be a big
> issue. But as Allen says, it would be better to future-proof your code by
> using KDateTime rather than QDateTime for compatibility with other parts of
> kdepimlibs and kdepim. I see that you are converting date/time values to
> text for storage - you will need in that case to allow for storing the time
> zone name alongside the date and time. The time zone name is obtainable by
> KDateTime::timeZone()->name().
>
> A small note: QDateTime::currentDateTime() (and the equivalent KDateTime
> methods) are static, so you don't need an instance to call it with.

Why is KXmlRpcClient using QDateTime, by the way? Because KDateTime has no 
advantages and Xml-Rpc always uses UTC by default?

Additionally I got a bugreport for KBlogger which matches KXmlRpcClient, too:

> <member>
> <name>dateCreated</name>
> <value><datetime.iso8601>2006-08-21T03:43:53</datetime.iso8601></value>
> </member>
>
> Some picky parsers will tell that datetime.iso8601 is an unknown tag.
> This can be fixed by changing datetime.iso8601 to dateTime.iso8601,
> which is correct per specification.

I hope you can fix it.

Cheers,
Christian

_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/