[Kde-pim] [PATCH] kioslaves/sieve: fix small managesieve protocol violations

[Stephan Bosch]

Allen Winter schreef:
> On Saturday 04 August 2007 7:35:01 am Stephan Bosch wrote:
>   
>> Hello,
>>
>> I'm developing a managesieve server for the dovecot project 
>> (www.dovecot.org) and some of my users reported problems when using 
>> KMail as a client. I decided to investigate the problem myself and this 
>> resulted in a very small patch against the kioslaves/sieve implementation.
>>
>>     
> Stephan,
>
> Thanks for the patch.
> Hamish?  Do you approve of the patch?
>
> The patch contains a new i18n() string, and we can't have any
> new i18n() strings for KDE 3.5.8.. but I'll find a way around that problem.
>   
If also take a look at the original source code you will see that this 
i18n() is copied literally from the lines above. Hmm, actually that is a 
bit ugly. Maybe you could postpone writing the error message till after 
the if block, by setting errmsg to the appropriate value. This avoids 
the duplication.

Regards,

Stephan.
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/