[Kde-pim] [PATCH] Change two methods in KPimIdentities

Thomas McGuire thomas.mcguire at gmx.net
Mon Aug 20 00:41:32 BST 2007


Hello,

I am asking for permission to change two methods of the Identity class of 
KPimIdentities. These methods are only used by KMail.

The rather small patch is attached.

The only thing that changes is that the transport for each identity is now 
stored as an int instead of a string.

This makes sense because the mailtransport library, which was recently 
introduced, uses int IDs as identifiers for the transports.
Although KMail could use names to identify transports, this would make the 
code more cumbersome in some places. Using IDs is more natural.

For reference, I also attached the KMail patch to deal with the changes. Note 
that the patch also gets rid of some cruft which is now handled inside 
mailtransport and fixes a bug or two (and does hopefully not introduce more).

OK to commit next monday?
(if there are no objections, I'll commit)

Regards,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kpimidentities.diff
Type: text/x-diff
Size: 1429 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070820/3f3e2946/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kmail.diff
Type: text/x-diff
Size: 24409 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20070820/3f3e2946/attachment-0001.diff>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list