[Kde-pim] Threaded ldap search class

Szombathelyi György gyurco at freemail.hu
Tue Apr 10 08:45:52 BST 2007


Hello,

Seems you read my comment in LdapSearch::Private::startSearch :)

About the QString->LdapDN conversion: go ahead, that was just my 
laziness why I didn't do it before.

About the threaded search: The duplication of most of LdapSearch into 
LdapSearchThread is a no-go, that should be integrated directly into 
LdapSearch. If it works reliable, there's no reason to keep the 
QTimer::singleShot() method.
Also, the waitForResult() should be merged with result(), there's no 
point to keep it seperate.

P.S.: Is there really a forever{} construct in Qt?

Bye,
György
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/



More information about the kde-pim mailing list