[Kde-pim] [patch] for korganizer 101696

[Reinhold Kainhofer]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Sonntag, 10. Dezember 2006 12:22 schrieb Martin Koller:
> attached you find a patch against the issue
>
> https://bugs.kde.org/show_bug.cgi?id=101696
>
> The problem is a recursion where 2 TODOs relate to each other.
>
> Please give me a brief feedback if it's ok for commit.


> +    // in case we found a related parent, which has no KOTodoViewItem yet,
> this must +    // be the case where 2 items refer to each other, therefore
> simply create item as root item +    if ( *itemIterator == 0 ) {
> +      todo->setRelatedTo(0);  // break the recursion, else we will have
> troubles later +      todoItem = new
> KOTodoViewItem(mTodoListView,todo,this);

The only problem I can see is that todo->setRelatedTo(0) completely removes 
the relation from the second todo. So, when you save that file, the second 
to-do is no longer related to the first at all.

Apart from that I don't seen any problem. The patch has my okay.

Cheers,
Reinhold
- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, Vienna University of Technology, Austria
email: reinhold at kainhofer.com, http://reinhold.kainhofer.com/
 * Financial and Actuarial Mathematics, TU Wien, http://www.fam.tuwien.ac.at/
 * K Desktop Environment, http://www.kde.org, KOrganizer maintainer
 * Chorvereinigung "Jung-Wien", http://www.jung-wien.at/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFFgo3ZTqjEwhXvPN0RAqPUAKCTHc+xu+EJxcFYffb1nkhqgOlRQgCfeTmG
phYR5GA+OW6sfxtL1YNeh6s=
=QWeN
-----END PGP SIGNATURE-----
_______________________________________________
kde-pim mailing list
kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
kde-pim home page at http://pim.kde.org/