Comparing KHTML in Quanta and Konq

[Carsten Pfeiffer]

-----BEGIN PGP SIGNED MESSAGE-----

On Thursday 29 May 2003 13:46, Waldo Bastian wrote:

> This code looks very broken. It checks for objId() == saveId in
> notifyHistoryEntry() but it seems to forget that objId is only unique for a
> give dcop client and, as far as I can see, objId() will always return
> "KonqHistoryManager".
>
> Instead, it should compare dcopClient()->appId() with
> dcopClient()->senderId. (See patch)

Indeed. Can you move this into a method isSenderOfBroadcast() or something 
like that and commit?

> I also noticed that notifyHistoryEntry gets called up to 4 times for a
> single URL, probably due to caption changes or something. Not emitting
> emitAddToHistory for pending entries would help there, as would delaying
> the actual saving a little with a timer (500ms or so?).

But that would defeat part of the purpose of the history. E.g. you visit a URL 
and konq crashes while parsing/rendering, whatever. You don't want to search 
where you got the original URL from, you want to get it from the history.

OTOH, there is this crash-plugin now. I never tested it tho.

Maybe it would suffice to compare the timestamps. Save only the first pending 
entry and the confirming entry, but no updates in between (are there really 
any, or is this due to redirections?`).

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----

iQEVAwUBPtYA4aWgYMJuwmZtAQFd4Af/RNAwZ7Qfxg7P/nY48vpDeWFuYY+tPJKD
dnRxyn6MUC/W7f8GFNV+y+dRsbKaz8DyxezgVjUGrnFmtTwh+6M0fgChL5DaGrjG
uls+za2XmrhY5XeUHwnAu4Uhzi/SwwHtJ8xowf/D2GO0tE/Fiwa3lvMOvPx2CsW+
nfPAlzprMJ82YoCRVGetziFExQNWgRyxhO510L1Q6vPEX2e5Ef2mns6GbrZrKNgq
2H8ioIUx6mYks81i0ISjAlyhmQPkAVbve53cVBAvkrjTrg5HoD1H/Btc5eYk9eQc
eGWBzIjlnp50lr/hF6Bxivh+K9PjMqjuw8zqJzxiTS87zk5THiiL0Q==
=Di8B
-----END PGP SIGNATURE-----