Review Request 127172: PPTP authentication dialog: focus is now automatically set on "password" textbox.

Tomasz Bywalec t.bywalec at gmail.com
Sat Mar 5 15:34:40 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127172/
-----------------------------------------------------------

(Updated March 5, 2016, 3:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for Network Management.


Changes
-------

Submitted with commit ccc43a548c62d8aa2031446bfb23bd294b0b4d97 by Lamarque V. Souza on behalf of Tomasz Bywalec to branch 0.9.3.


Repository: plasma-nm


Description
-------

PPTP authentication dialog: focus is now automatically set on "password" textbox.

Also:
    
* The dialog's width is now the same as width of OpenVPN authentication dialog.
* "Show password" checkbox is now aligned to the left.

=================================================================================

Motivation for this change:

1. User experience: when keyboard focus is automatically set on "password" textbox, then user can start entering password immediately when the dialog is displayed.

2. Consistency of look&behaviour between PPTP and OpenVPN authentication dialogs.


Diffs
-----

  vpn/pptp/pptpauth.cpp a2b1255 
  vpn/pptp/pptpauth.ui 86bbdb8 

Diff: https://git.reviewboard.kde.org/r/127172/diff/


Testing
-------

Tested on Slackware64-current.


Thanks,

Tomasz Bywalec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20160305/28be702b/attachment.html>


More information about the kde-networkmanager mailing list