Review Request 127172: PPTP authentication dialog: focus is now automatically set on "password" textbox.

[Tomasz Bywalec]

> On Март 1, 2016, 9:10 д.п., Jan Grulich wrote:
> > Ship It!

I'm afraid I don't have commit access to KDE git repository, and it seems I have too short contribution history (1 patch :-) to be granted such access. It was suggested to me that perhaps someone else, who has the access, can commit the patch for me. Would it be possible for someone working on plasma-nm to do this? Apologies if it causes any problem.


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127172/#review92974
-----------------------------------------------------------


On Фев. 24, 2016, 11:05 п.п., Tomasz Bywalec wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127172/
> -----------------------------------------------------------
> 
> (Updated Фев. 24, 2016, 11:05 п.п.)
> 
> 
> Review request for Network Management.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> PPTP authentication dialog: focus is now automatically set on "password" textbox.
> 
> Also:
>     
> * The dialog's width is now the same as width of OpenVPN authentication dialog.
> * "Show password" checkbox is now aligned to the left.
> 
> =================================================================================
> 
> Motivation for this change:
> 
> 1. User experience: when keyboard focus is automatically set on "password" textbox, then user can start entering password immediately when the dialog is displayed.
> 
> 2. Consistency of look&behaviour between PPTP and OpenVPN authentication dialogs.
> 
> 
> Diffs
> -----
> 
>   vpn/pptp/pptpauth.cpp a2b1255 
>   vpn/pptp/pptpauth.ui 86bbdb8 
> 
> Diff: https://git.reviewboard.kde.org/r/127172/diff/
> 
> 
> Testing
> -------
> 
> Tested on Slackware64-current.
> 
> 
> Thanks,
> 
> Tomasz Bywalec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20160305/f1429766/attachment.html>