Review Request 128487: Default to WPA2-PSK and WPA2-EAP when getting security type from connection settings

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128487/#review97612
-----------------------------------------------------------




src/utils.cpp (line 439)
<https://git.reviewboard.kde.org/r/128487/#comment65799>

    You could have simplified this code by just removing the code between this if-clause until the else-clause.



src/utils.cpp (line 446)
<https://git.reviewboard.kde.org/r/128487/#comment65800>

    Same here.


- Lamarque Souza


On July 19, 2016, 1:07 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128487/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 1:07 p.m.)
> 
> 
> Review request for Network Management and Lamarque Souza.
> 
> 
> Bugs: 365704
>     http://bugs.kde.org/show_bug.cgi?id=365704
> 
> 
> Repository: networkmanager-qt
> 
> 
> Description
> -------
> 
> I think that wpa2 should be preferred over wpa (as more widely used and more secured), althought it's just a label and the result doesn't matter that much.
> 
> 
> Diffs
> -----
> 
>   src/utils.cpp f639e30 
> 
> Diff: https://git.reviewboard.kde.org/r/128487/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20160719/21392634/attachment-0001.html>