<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128487/">https://git.reviewboard.kde.org/r/128487/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128487/diff/1/?file=472062#file472062line439" style="color: black; font-weight: bold; text-decoration: underline;">src/utils.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">439</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">wifiSecuritySetting</span><span class="o">-></span><span class="n">proto</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">WirelessSecuritySetting</span><span class="o">::</span><span class="n">Rsn</span><span class="p">)</span> <span class="o">&&</span> <span class="o">!</span><span class="n">wifiSecuritySetting</span><span class="o">-></span><span class="n">proto</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">WirelessSecuritySetting</span><span class="o">::</span><span class="n">Wpa</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">439</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">wifiSecuritySetting</span><span class="o">-></span><span class="n">proto</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">WirelessSecuritySetting</span><span class="o">::</span><span class="n">Rsn</span><span class="p">)</span> <span class="o">&&</span> <span class="o">!</span><span class="n">wifiSecuritySetting</span><span class="o">-></span><span class="n">proto</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">WirelessSecuritySetting</span><span class="o">::</span><span class="n">Wpa</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You could have simplified this code by just removing the code between this if-clause until the else-clause.</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128487/diff/1/?file=472062#file472062line446" style="color: black; font-weight: bold; text-decoration: underline;">src/utils.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">444</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">wifiSecuritySetting</span><span class="o">-></span><span class="n">proto</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">WirelessSecuritySetting</span><span class="o">::</span><span class="n">Rsn</span><span class="p">)</span> <span class="o">&&</span> <span class="o">!</span><span class="n">wifiSecuritySetting</span><span class="o">-></span><span class="n">proto</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">WirelessSecuritySetting</span><span class="o">::</span><span class="n">Wpa</span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">446</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">wifiSecuritySetting</span><span class="o">-></span><span class="n">proto</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">WirelessSecuritySetting</span><span class="o">::</span><span class="n">Rsn</span><span class="p">)</span> <span class="o">&&</span> <span class="o">!</span><span class="n">wifiSecuritySetting</span><span class="o">-></span><span class="n">proto</span><span class="p">().</span><span class="n">contains</span><span class="p">(</span><span class="n">WirelessSecuritySetting</span><span class="o">::</span><span class="n">Wpa</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Same here.</p></pre>
</div>
</div>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On July 19th, 2016, 1:07 p.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated July 19, 2016, 1:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=365704">365704</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
networkmanager-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think that wpa2 should be preferred over wpa (as more widely used and more secured), althought it's just a label and the result doesn't matter that much.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/utils.cpp <span style="color: grey">(f639e30)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128487/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>