Review Request 126715: Re-check connection state and other properties to be sure they are actual (version 2)
Lamarque Souza
lamarque at kde.org
Mon Jan 11 11:18:05 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126715/#review90877
-----------------------------------------------------------
Ship it!
Ship It!
- Lamarque Souza
On Jan. 11, 2016, 11:16 a.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126715/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 11:16 a.m.)
>
>
> Review request for Network Management and Lamarque Souza.
>
>
> Bugs: 352326
> http://bugs.kde.org/show_bug.cgi?id=352326
>
>
> Repository: networkmanager-qt
>
>
> Description
> -------
>
> Previous review request: 126029
>
> My previous solution doesn't seem to work, probably because I was sending signals from constructor. I changed this to asynchronous calls so signals should be now emitted when ActiveConnection is properly constructed.
>
>
> Diffs
> -----
>
> src/activeconnection.cpp f29ca67
> src/activeconnection_p.h 75a7c4e
>
> Diff: https://git.reviewboard.kde.org/r/126715/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20160111/e879c5d5/attachment-0001.html>
More information about the kde-networkmanager
mailing list