Review Request 126715: Re-check connection state and other properties to be sure they are actual (version 2)

Jan Grulich jgrulich at redhat.com
Mon Jan 11 11:16:08 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126715/
-----------------------------------------------------------

(Updated Led. 11, 2016, 11:16 dop.)


Review request for Network Management and Lamarque Souza.


Changes
-------

Updated patch fixing mentioned issues.


Bugs: 352326
    http://bugs.kde.org/show_bug.cgi?id=352326


Repository: networkmanager-qt


Description
-------

Previous review request: 126029

My previous solution doesn't seem to work, probably because I was sending signals from constructor. I changed this to asynchronous calls so signals should be now emitted when ActiveConnection is properly constructed.


Diffs (updated)
-----

  src/activeconnection.cpp f29ca67 
  src/activeconnection_p.h 75a7c4e 

Diff: https://git.reviewboard.kde.org/r/126715/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20160111/f3200d04/attachment.html>


More information about the kde-networkmanager mailing list