Review Request 125543: OpenVPN improvements
Jan Grulich
jgrulich at redhat.com
Wed Oct 7 11:52:17 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125543/
-----------------------------------------------------------
(Updated Říj. 7, 2015, 11:52 dop.)
Review request for Network Management and Lamarque Souza.
Changes
-------
Fixed mentioned issues.
Repository: plasma-nm
Description
-------
While adding tooltips to our editor for OpenVPN properties I noticed that we are missing options for few properties which are already implemented in nm-connection-editor and also that we have different names for some options. This patch adds those missing properties and changes some labels so they match NM implementation. I also fixed some coding style issues and used QLatin1String where it was possible.
Diffs (updated)
-----
vpn/openvpn/nm-openvpn-service.h 39e2251
vpn/openvpn/openvpn.ui b68e27e
vpn/openvpn/openvpnadvanced.ui 687d7d1
vpn/openvpn/openvpnadvancedwidget.cpp fe63958
Diff: https://git.reviewboard.kde.org/r/125543/diff/
Testing
-------
Thanks,
Jan Grulich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20151007/cff9d0ef/attachment-0001.html>
More information about the kde-networkmanager
mailing list