Review Request 125543: OpenVPN improvements

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125543/#review86446
-----------------------------------------------------------



vpn/openvpn/openvpnadvanced.ui (line 226)
<https://git.reviewboard.kde.org/r/125543/#comment59559>

    Since this is a tooltip I prefer not to use abbreviations (like MSS) here, use "maximum segment size" instead. TCP is ok because those three letters are well known today, more than their meaning (transmission control protocol).



vpn/openvpn/openvpnadvancedwidget.cpp (line 193)
<https://git.reviewboard.kde.org/r/125543/#comment59560>

    const



vpn/openvpn/openvpnadvancedwidget.cpp (line 247)
<https://git.reviewboard.kde.org/r/125543/#comment59561>

    You can use QLatin1String around "http" here. I think even QStringLiteral works here too.



vpn/openvpn/openvpnadvancedwidget.cpp (line 249)
<https://git.reviewboard.kde.org/r/125543/#comment59562>

    Same here.



vpn/openvpn/openvpnadvancedwidget.cpp (line 261)
<https://git.reviewboard.kde.org/r/125543/#comment59563>

    And here.


- Lamarque Souza


On Oct. 7, 2015, 8:17 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125543/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 8:17 a.m.)
> 
> 
> Review request for Network Management and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> While adding tooltips to our editor for OpenVPN properties I noticed that we are missing options for few properties which are already implemented in nm-connection-editor and also that we have different names for some options. This patch adds those missing properties and changes some labels so they match NM implementation. I also fixed some coding style issues and used QLatin1String where it was possible.
> 
> 
> Diffs
> -----
> 
>   vpn/openvpn/openvpnadvancedwidget.cpp fe63958 
>   vpn/openvpn/openvpnadvanced.ui 687d7d1 
>   vpn/openvpn/openvpn.ui b68e27e 
>   vpn/openvpn/nm-openvpn-service.h 39e2251 
> 
> Diff: https://git.reviewboard.kde.org/r/125543/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20151007/1088a631/attachment.html>