Review Request 126041: Allow access for all users by default for newly created connections

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126041/#review88294
-----------------------------------------------------------


I still do not get the reason for this. If a connection is of type system then NetworkManager will store its secrets (in plain text in most cases), that is a security risk and there will be no kwallet involved. Even if you uncheck "All users may connect to this network" and selects all users (is that what you want?), that also means any user will be able to read the password.

- Lamarque Souza


On Nov. 12, 2015, 11 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126041/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 11 a.m.)
> 
> 
> Review request for Network Management and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> See summary, nm-connection-editor also have this by default. Reason for this are LiveCDs, where when you create system connections then they should be also in the installed system. Making all connections available for all also shouldn't be a problem due to security reasons because passwords are still saved into KWallet by default just for one user.
> 
> 
> Diffs
> -----
> 
>   libs/editor/connectiondetaileditor.cpp 7370bbb 
>   libs/editor/settings/ui/connectionwidget.ui 3111b54 
>   libs/handler.cpp 20db520 
> 
> Diff: https://git.reviewboard.kde.org/r/126041/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20151112/273b4d7b/attachment.html>