<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126041/">https://git.reviewboard.kde.org/r/126041/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I still do not get the reason for this. If a connection is of type system then NetworkManager will store its secrets (in plain text in most cases), that is a security risk and there will be no kwallet involved. Even if you uncheck "All users may connect to this network" and selects all users (is that what you want?), that also means any user will be able to read the password.</p></pre>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On November 12th, 2015, 11 a.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2015, 11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See summary, nm-connection-editor also have this by default. Reason for this are LiveCDs, where when you create system connections then they should be also in the installed system. Making all connections available for all also shouldn't be a problem due to security reasons because passwords are still saved into KWallet by default just for one user.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/editor/connectiondetaileditor.cpp <span style="color: grey">(7370bbb)</span></li>
<li>libs/editor/settings/ui/connectionwidget.ui <span style="color: grey">(3111b54)</span></li>
<li>libs/handler.cpp <span style="color: grey">(20db520)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126041/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>