Review Request 122070: Prepare for NetworkManager 1.0.0
Lamarque Souza
lamarque at kde.org
Thu Jan 15 10:20:36 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122070/#review74055
-----------------------------------------------------------
Ship it!
Ship It!
- Lamarque Souza
On Jan. 15, 2015, 9:41 a.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122070/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 9:41 a.m.)
>
>
> Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
>
>
> Repository: networkmanager-qt
>
>
> Description
> -------
>
> Since NetworkManager 1.0.0 there are some changes which require using headears from different location. They started to install nm-setting-foo.h headers under /usr/include/libnm/ instead of /usr/include/NetworkManager as before. Old headers are still provided for compatibility, but they are not updated anymore, which means if we want to add new properties (like I did with autoconnect-priority) we need to use the new location. Some properties are deprecated, but we should keep them there for compatibility, they would be just ignored by NetworkManager. I also improved FindNetworkManager.cmake to search for new library when user has NM 1.0.0 and newer.
>
>
> Diffs
> -----
>
> autotests/CMakeLists.txt d458d39
> autotests/settings/8021xsettingtest.cpp 78932a9
> autotests/settings/adslsettingtest.cpp 41dc6e7
> autotests/settings/bluetoothsettingtest.cpp 45adf08
> autotests/settings/bondsettingtest.cpp 68b8b8d
> autotests/settings/bridgeportsettingtest.cpp 8810046
> autotests/settings/bridgesettingtest.cpp 22baeb1
> autotests/settings/cdmasettingtest.cpp c05b879
> autotests/settings/connectionsettingtest.cpp b4d58bf
> autotests/settings/gsmsettingtest.cpp 08ffa40
> autotests/settings/infinibandsettingtest.cpp 4dac696
> autotests/settings/ipv4settingtest.cpp fa9bb2b
> autotests/settings/ipv6settingtest.cpp b2011df
> autotests/settings/wiredsettingtest.cpp 02bf947
> autotests/settings/wirelesssecuritysettingtest.cpp 3d88476
> autotests/settings/olpcmeshsettingtest.cpp 93174b6
> autotests/settings/pppoesettingtest.cpp fff5e9c
> autotests/settings/pppsettingtest.cpp 7d7aa8b
> autotests/settings/serialsettingtest.cpp 988d35f
> autotests/settings/vlansettingtest.cpp 2175b0c
> autotests/settings/wimaxsettingtest.cpp ebb47cb
> src/settings/infinibandsetting_p.h eb6d2d9
> src/settings/ipv4setting.h f913eab
> src/settings/ipv4setting.cpp 1dc2568
> src/settings/ipv6setting.h bc60980
> src/settings/infinibandsetting.h 426b24d
> src/settings/infinibandsetting.cpp 84707ca
> src/settings/gsmsetting.h 8c33daf
> src/settings/gsmsetting.cpp af4d2ac
> src/settings/connectionsettings.h ee06384
> src/settings/connectionsettings.cpp bf491e5
> src/settings/connectionsettings_p.h 82ccb50
> src/settings/genericsetting.cpp 7c3ce5c
> src/settings/bridgesetting.cpp 45c6d91
> src/settings/cdmasetting.cpp af6fc43
> src/settings/ipv6setting.cpp d69cdc0
> src/settings/olpcmeshsetting.cpp 2bdd23f
> src/settings/pppoesetting.cpp dbddd38
> src/settings/pppsetting.cpp 4d4b870
> src/settings/security8021xsetting.cpp aab4da3
> src/settings/serialsetting.cpp f373402
> src/settings/setting.h b725118
> src/settings/setting.cpp a0b6c38
> src/settings/teamsetting.h eef98b4
> src/settings/teamsetting.cpp 802b93d
> src/settings/vlansetting.h 3157a68
> src/settings/vlansetting.cpp f3e89f6
> src/settings/vpnsetting.cpp 210093b
> src/settings/wimaxsetting.cpp 7c23daa
> src/settings/wiredsetting.cpp b6bd11f
> src/settings/wirelesssecuritysetting.cpp 9c2c30d
> src/settings/wirelesssetting.cpp 1a94823
> src/wirelessdevice.cpp 434fea3
> src/settings/adslsetting.cpp a6a9831
> src/settings/bluetoothsetting.cpp 4a7d566
> src/settings/bondsetting.h 8c3cb68
> src/settings/bondsetting.cpp 3a20d8f
> src/settings/bridgeportsetting.cpp bce2575
> src/settings/bridgesetting.h 67105c6
> autotests/settings/wirelesssettingtest.cpp c391ac2
> cmake/FindNetworkManager.cmake 89c55e4
> src/CMakeLists.txt f7abff4
> src/connection.cpp 3137c05
> src/fakenetwork/CMakeLists.txt 3c30e2a
> src/ipconfig.h cc85fc5
> src/manager.cpp b0dfe00
> src/secretagent.cpp 55da800
>
> Diff: https://git.reviewboard.kde.org/r/122070/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Grulich
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150115/6cdddc78/attachment.html>
More information about the kde-networkmanager
mailing list