<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122070/">https://git.reviewboard.kde.org/r/122070/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On January 15th, 2015, 9:41 a.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, Lukáš Tinkl and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2015, 9:41 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
networkmanager-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since NetworkManager 1.0.0 there are some changes which require using headears from different location. They started to install nm-setting-foo.h headers under /usr/include/libnm/ instead of /usr/include/NetworkManager as before. Old headers are still provided for compatibility, but they are not updated anymore, which means if we want to add new properties (like I did with autoconnect-priority) we need to use the new location. Some properties are deprecated, but we should keep them there for compatibility, they would be just ignored by NetworkManager. I also improved FindNetworkManager.cmake to search for new library when user has NM 1.0.0 and newer.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(d458d39)</span></li>
<li>autotests/settings/8021xsettingtest.cpp <span style="color: grey">(78932a9)</span></li>
<li>autotests/settings/adslsettingtest.cpp <span style="color: grey">(41dc6e7)</span></li>
<li>autotests/settings/bluetoothsettingtest.cpp <span style="color: grey">(45adf08)</span></li>
<li>autotests/settings/bondsettingtest.cpp <span style="color: grey">(68b8b8d)</span></li>
<li>autotests/settings/bridgeportsettingtest.cpp <span style="color: grey">(8810046)</span></li>
<li>autotests/settings/bridgesettingtest.cpp <span style="color: grey">(22baeb1)</span></li>
<li>autotests/settings/cdmasettingtest.cpp <span style="color: grey">(c05b879)</span></li>
<li>autotests/settings/connectionsettingtest.cpp <span style="color: grey">(b4d58bf)</span></li>
<li>autotests/settings/gsmsettingtest.cpp <span style="color: grey">(08ffa40)</span></li>
<li>autotests/settings/infinibandsettingtest.cpp <span style="color: grey">(4dac696)</span></li>
<li>autotests/settings/ipv4settingtest.cpp <span style="color: grey">(fa9bb2b)</span></li>
<li>autotests/settings/ipv6settingtest.cpp <span style="color: grey">(b2011df)</span></li>
<li>autotests/settings/wiredsettingtest.cpp <span style="color: grey">(02bf947)</span></li>
<li>autotests/settings/wirelesssecuritysettingtest.cpp <span style="color: grey">(3d88476)</span></li>
<li>autotests/settings/olpcmeshsettingtest.cpp <span style="color: grey">(93174b6)</span></li>
<li>autotests/settings/pppoesettingtest.cpp <span style="color: grey">(fff5e9c)</span></li>
<li>autotests/settings/pppsettingtest.cpp <span style="color: grey">(7d7aa8b)</span></li>
<li>autotests/settings/serialsettingtest.cpp <span style="color: grey">(988d35f)</span></li>
<li>autotests/settings/vlansettingtest.cpp <span style="color: grey">(2175b0c)</span></li>
<li>autotests/settings/wimaxsettingtest.cpp <span style="color: grey">(ebb47cb)</span></li>
<li>src/settings/infinibandsetting_p.h <span style="color: grey">(eb6d2d9)</span></li>
<li>src/settings/ipv4setting.h <span style="color: grey">(f913eab)</span></li>
<li>src/settings/ipv4setting.cpp <span style="color: grey">(1dc2568)</span></li>
<li>src/settings/ipv6setting.h <span style="color: grey">(bc60980)</span></li>
<li>src/settings/infinibandsetting.h <span style="color: grey">(426b24d)</span></li>
<li>src/settings/infinibandsetting.cpp <span style="color: grey">(84707ca)</span></li>
<li>src/settings/gsmsetting.h <span style="color: grey">(8c33daf)</span></li>
<li>src/settings/gsmsetting.cpp <span style="color: grey">(af4d2ac)</span></li>
<li>src/settings/connectionsettings.h <span style="color: grey">(ee06384)</span></li>
<li>src/settings/connectionsettings.cpp <span style="color: grey">(bf491e5)</span></li>
<li>src/settings/connectionsettings_p.h <span style="color: grey">(82ccb50)</span></li>
<li>src/settings/genericsetting.cpp <span style="color: grey">(7c3ce5c)</span></li>
<li>src/settings/bridgesetting.cpp <span style="color: grey">(45c6d91)</span></li>
<li>src/settings/cdmasetting.cpp <span style="color: grey">(af6fc43)</span></li>
<li>src/settings/ipv6setting.cpp <span style="color: grey">(d69cdc0)</span></li>
<li>src/settings/olpcmeshsetting.cpp <span style="color: grey">(2bdd23f)</span></li>
<li>src/settings/pppoesetting.cpp <span style="color: grey">(dbddd38)</span></li>
<li>src/settings/pppsetting.cpp <span style="color: grey">(4d4b870)</span></li>
<li>src/settings/security8021xsetting.cpp <span style="color: grey">(aab4da3)</span></li>
<li>src/settings/serialsetting.cpp <span style="color: grey">(f373402)</span></li>
<li>src/settings/setting.h <span style="color: grey">(b725118)</span></li>
<li>src/settings/setting.cpp <span style="color: grey">(a0b6c38)</span></li>
<li>src/settings/teamsetting.h <span style="color: grey">(eef98b4)</span></li>
<li>src/settings/teamsetting.cpp <span style="color: grey">(802b93d)</span></li>
<li>src/settings/vlansetting.h <span style="color: grey">(3157a68)</span></li>
<li>src/settings/vlansetting.cpp <span style="color: grey">(f3e89f6)</span></li>
<li>src/settings/vpnsetting.cpp <span style="color: grey">(210093b)</span></li>
<li>src/settings/wimaxsetting.cpp <span style="color: grey">(7c23daa)</span></li>
<li>src/settings/wiredsetting.cpp <span style="color: grey">(b6bd11f)</span></li>
<li>src/settings/wirelesssecuritysetting.cpp <span style="color: grey">(9c2c30d)</span></li>
<li>src/settings/wirelesssetting.cpp <span style="color: grey">(1a94823)</span></li>
<li>src/wirelessdevice.cpp <span style="color: grey">(434fea3)</span></li>
<li>src/settings/adslsetting.cpp <span style="color: grey">(a6a9831)</span></li>
<li>src/settings/bluetoothsetting.cpp <span style="color: grey">(4a7d566)</span></li>
<li>src/settings/bondsetting.h <span style="color: grey">(8c3cb68)</span></li>
<li>src/settings/bondsetting.cpp <span style="color: grey">(3a20d8f)</span></li>
<li>src/settings/bridgeportsetting.cpp <span style="color: grey">(bce2575)</span></li>
<li>src/settings/bridgesetting.h <span style="color: grey">(67105c6)</span></li>
<li>autotests/settings/wirelesssettingtest.cpp <span style="color: grey">(c391ac2)</span></li>
<li>cmake/FindNetworkManager.cmake <span style="color: grey">(89c55e4)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(f7abff4)</span></li>
<li>src/connection.cpp <span style="color: grey">(3137c05)</span></li>
<li>src/fakenetwork/CMakeLists.txt <span style="color: grey">(3c30e2a)</span></li>
<li>src/ipconfig.h <span style="color: grey">(cc85fc5)</span></li>
<li>src/manager.cpp <span style="color: grey">(b0dfe00)</span></li>
<li>src/secretagent.cpp <span style="color: grey">(55da800)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122070/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>