Review Request 124922: Replace "show password" checkboxes with a custom password field

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124922/#review84339
-----------------------------------------------------------


Otherwise looks good to me, except the one small issue


libs/editor/widgets/passwordfield.cpp (line 31)
<https://git.reviewboard.kde.org/r/124922/#comment58405>

    tr()? :)


- Lukáš Tinkl


On Srp. 25, 2015, 4:14 odp., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124922/
> -----------------------------------------------------------
> 
> (Updated Srp. 25, 2015, 4:14 odp.)
> 
> 
> Review request for Network Management and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Add a new custom password field which has a small icon switch for hiding/showing password instead of using checkboxes. I got inspiration from https://git.reviewboard.kde.org/r/124698.
> 
> Screenshot:
> ![New password field](https://jgrulich.fedorapeople.org/password-field.png)
> 
> 
> Diffs
> -----
> 
>   libs/editor/CMakeLists.txt 2cf4ebd 
>   libs/editor/settings/cdmawidget.h e444aa8 
>   libs/editor/settings/cdmawidget.cpp 580b471 
>   libs/editor/settings/gsmwidget.h 7cd4725 
>   libs/editor/settings/gsmwidget.cpp cbc911d 
>   libs/editor/settings/pppoewidget.h 3404012 
>   libs/editor/settings/pppoewidget.cpp dee8e9f 
>   libs/editor/settings/security802-1x.h 4b1e4b6 
>   libs/editor/settings/security802-1x.cpp e7e1e89 
>   libs/editor/settings/ui/802-1x.ui 093eddc 
>   libs/editor/settings/ui/cdma.ui 871b3f4 
>   libs/editor/settings/ui/gsm.ui cfe7153 
>   libs/editor/settings/ui/pppoe.ui 71ed477 
>   libs/editor/settings/ui/wifisecurity.ui e129e50 
>   libs/editor/settings/wifisecurity.h 454fcc0 
>   libs/editor/settings/wifisecurity.cpp 08bfdd8 
>   libs/editor/widgets/passwordfield.h PRE-CREATION 
>   libs/editor/widgets/passwordfield.cpp PRE-CREATION 
>   vpn/l2tp/l2tp.ui be1ddaa 
>   vpn/l2tp/l2tpauth.h 7fd964d 
>   vpn/l2tp/l2tpauth.cpp d10062b 
>   vpn/l2tp/l2tpauth.ui 32ed48b 
>   vpn/l2tp/l2tpwidget.h 96d7f72 
>   vpn/l2tp/l2tpwidget.cpp 0413436 
>   vpn/openconnect/openconnectauth.cpp f325386 
>   vpn/openswan/openswan.ui 8f87ed1 
>   vpn/openswan/openswanauth.h 397fcda 
>   vpn/openswan/openswanauth.cpp 369d1c0 
>   vpn/openswan/openswanauth.ui b93a710 
>   vpn/openswan/openswanwidget.h 8f0ffbf 
>   vpn/openswan/openswanwidget.cpp 0ae788a 
>   vpn/openvpn/openvpn.ui 6307048 
>   vpn/openvpn/openvpnadvanced.ui 65570be 
>   vpn/openvpn/openvpnadvancedwidget.h 125e646 
>   vpn/openvpn/openvpnadvancedwidget.cpp f0794c0 
>   vpn/openvpn/openvpnauth.h 58651e5 
>   vpn/openvpn/openvpnauth.cpp 0853154 
>   vpn/openvpn/openvpnwidget.h 373f12d 
>   vpn/openvpn/openvpnwidget.cpp b541a0a 
>   vpn/pptp/pptpauth.h 506cbb1 
>   vpn/pptp/pptpauth.cpp 8c822ee 
>   vpn/pptp/pptpauth.ui ce1803f 
>   vpn/pptp/pptpprop.ui fa46764 
>   vpn/pptp/pptpwidget.h 6dbaede 
>   vpn/pptp/pptpwidget.cpp a4da495 
>   vpn/ssh/sshauth.h 6b296d9 
>   vpn/ssh/sshauth.cpp 69e170b 
>   vpn/ssh/sshauth.ui 12ad0da 
>   vpn/ssh/sshwidget.h 3dc8197 
>   vpn/ssh/sshwidget.cpp 0ca4f8c 
>   vpn/ssh/sshwidget.ui 2b44312 
>   vpn/sstp/sstpadvanced.ui 07239a9 
>   vpn/sstp/sstpauth.h 61c7556 
>   vpn/sstp/sstpauth.cpp 90df136 
>   vpn/sstp/sstpauth.ui 7ff4ac5 
>   vpn/sstp/sstpwidget.h 0147509 
>   vpn/sstp/sstpwidget.cpp 8b84834 
>   vpn/sstp/sstpwidget.ui 880ec37 
>   vpn/strongswan/strongswanauth.h 6f394d3 
>   vpn/strongswan/strongswanauth.cpp d899dc6 
>   vpn/strongswan/strongswanauth.ui 5c18cc9 
>   vpn/strongswan/strongswanprop.ui 3527552 
>   vpn/strongswan/strongswanwidget.h 068b2eb 
>   vpn/strongswan/strongswanwidget.cpp cfb4188 
>   vpn/vpnc/vpnc.ui f305974 
>   vpn/vpnc/vpncauth.h 2a0bc36 
>   vpn/vpnc/vpncauth.cpp 10414aa 
>   vpn/vpnc/vpncauth.ui 5c99684 
>   vpn/vpnc/vpncwidget.h 0a1393b 
>   vpn/vpnc/vpncwidget.cpp 6a777fe 
> 
> Diff: https://git.reviewboard.kde.org/r/124922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150825/8b4ba98c/attachment-0001.html>