<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124922/">https://git.reviewboard.kde.org/r/124922/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Otherwise looks good to me, except the one small issue</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124922/diff/1/?file=398089#file398089line31" style="color: black; font-weight: bold; text-decoration: underline;">libs/editor/widgets/passwordfield.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">31</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">toggleEchoModeAction</span><span class="o">-></span><span class="n">setToolTip</span><span class="p">(</span><span class="n">tr</span><span class="p">(</span><span class="s">"Change the visibility of the password"</span><span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">tr()? :)</p></pre>
</div>
</div>
<br />
<p>- Lukáš Tinkl</p>
<br />
<p>On srpen 25th, 2015, 4:14 odp. CEST, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Srp. 25, 2015, 4:14 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add a new custom password field which has a small icon switch for hiding/showing password instead of using checkboxes. I got inspiration from https://git.reviewboard.kde.org/r/124698.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Screenshot:
<img alt="New password field" src="https://jgrulich.fedorapeople.org/password-field.png" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /></p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/editor/CMakeLists.txt <span style="color: grey">(2cf4ebd)</span></li>
<li>libs/editor/settings/cdmawidget.h <span style="color: grey">(e444aa8)</span></li>
<li>libs/editor/settings/cdmawidget.cpp <span style="color: grey">(580b471)</span></li>
<li>libs/editor/settings/gsmwidget.h <span style="color: grey">(7cd4725)</span></li>
<li>libs/editor/settings/gsmwidget.cpp <span style="color: grey">(cbc911d)</span></li>
<li>libs/editor/settings/pppoewidget.h <span style="color: grey">(3404012)</span></li>
<li>libs/editor/settings/pppoewidget.cpp <span style="color: grey">(dee8e9f)</span></li>
<li>libs/editor/settings/security802-1x.h <span style="color: grey">(4b1e4b6)</span></li>
<li>libs/editor/settings/security802-1x.cpp <span style="color: grey">(e7e1e89)</span></li>
<li>libs/editor/settings/ui/802-1x.ui <span style="color: grey">(093eddc)</span></li>
<li>libs/editor/settings/ui/cdma.ui <span style="color: grey">(871b3f4)</span></li>
<li>libs/editor/settings/ui/gsm.ui <span style="color: grey">(cfe7153)</span></li>
<li>libs/editor/settings/ui/pppoe.ui <span style="color: grey">(71ed477)</span></li>
<li>libs/editor/settings/ui/wifisecurity.ui <span style="color: grey">(e129e50)</span></li>
<li>libs/editor/settings/wifisecurity.h <span style="color: grey">(454fcc0)</span></li>
<li>libs/editor/settings/wifisecurity.cpp <span style="color: grey">(08bfdd8)</span></li>
<li>libs/editor/widgets/passwordfield.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/editor/widgets/passwordfield.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>vpn/l2tp/l2tp.ui <span style="color: grey">(be1ddaa)</span></li>
<li>vpn/l2tp/l2tpauth.h <span style="color: grey">(7fd964d)</span></li>
<li>vpn/l2tp/l2tpauth.cpp <span style="color: grey">(d10062b)</span></li>
<li>vpn/l2tp/l2tpauth.ui <span style="color: grey">(32ed48b)</span></li>
<li>vpn/l2tp/l2tpwidget.h <span style="color: grey">(96d7f72)</span></li>
<li>vpn/l2tp/l2tpwidget.cpp <span style="color: grey">(0413436)</span></li>
<li>vpn/openconnect/openconnectauth.cpp <span style="color: grey">(f325386)</span></li>
<li>vpn/openswan/openswan.ui <span style="color: grey">(8f87ed1)</span></li>
<li>vpn/openswan/openswanauth.h <span style="color: grey">(397fcda)</span></li>
<li>vpn/openswan/openswanauth.cpp <span style="color: grey">(369d1c0)</span></li>
<li>vpn/openswan/openswanauth.ui <span style="color: grey">(b93a710)</span></li>
<li>vpn/openswan/openswanwidget.h <span style="color: grey">(8f0ffbf)</span></li>
<li>vpn/openswan/openswanwidget.cpp <span style="color: grey">(0ae788a)</span></li>
<li>vpn/openvpn/openvpn.ui <span style="color: grey">(6307048)</span></li>
<li>vpn/openvpn/openvpnadvanced.ui <span style="color: grey">(65570be)</span></li>
<li>vpn/openvpn/openvpnadvancedwidget.h <span style="color: grey">(125e646)</span></li>
<li>vpn/openvpn/openvpnadvancedwidget.cpp <span style="color: grey">(f0794c0)</span></li>
<li>vpn/openvpn/openvpnauth.h <span style="color: grey">(58651e5)</span></li>
<li>vpn/openvpn/openvpnauth.cpp <span style="color: grey">(0853154)</span></li>
<li>vpn/openvpn/openvpnwidget.h <span style="color: grey">(373f12d)</span></li>
<li>vpn/openvpn/openvpnwidget.cpp <span style="color: grey">(b541a0a)</span></li>
<li>vpn/pptp/pptpauth.h <span style="color: grey">(506cbb1)</span></li>
<li>vpn/pptp/pptpauth.cpp <span style="color: grey">(8c822ee)</span></li>
<li>vpn/pptp/pptpauth.ui <span style="color: grey">(ce1803f)</span></li>
<li>vpn/pptp/pptpprop.ui <span style="color: grey">(fa46764)</span></li>
<li>vpn/pptp/pptpwidget.h <span style="color: grey">(6dbaede)</span></li>
<li>vpn/pptp/pptpwidget.cpp <span style="color: grey">(a4da495)</span></li>
<li>vpn/ssh/sshauth.h <span style="color: grey">(6b296d9)</span></li>
<li>vpn/ssh/sshauth.cpp <span style="color: grey">(69e170b)</span></li>
<li>vpn/ssh/sshauth.ui <span style="color: grey">(12ad0da)</span></li>
<li>vpn/ssh/sshwidget.h <span style="color: grey">(3dc8197)</span></li>
<li>vpn/ssh/sshwidget.cpp <span style="color: grey">(0ca4f8c)</span></li>
<li>vpn/ssh/sshwidget.ui <span style="color: grey">(2b44312)</span></li>
<li>vpn/sstp/sstpadvanced.ui <span style="color: grey">(07239a9)</span></li>
<li>vpn/sstp/sstpauth.h <span style="color: grey">(61c7556)</span></li>
<li>vpn/sstp/sstpauth.cpp <span style="color: grey">(90df136)</span></li>
<li>vpn/sstp/sstpauth.ui <span style="color: grey">(7ff4ac5)</span></li>
<li>vpn/sstp/sstpwidget.h <span style="color: grey">(0147509)</span></li>
<li>vpn/sstp/sstpwidget.cpp <span style="color: grey">(8b84834)</span></li>
<li>vpn/sstp/sstpwidget.ui <span style="color: grey">(880ec37)</span></li>
<li>vpn/strongswan/strongswanauth.h <span style="color: grey">(6f394d3)</span></li>
<li>vpn/strongswan/strongswanauth.cpp <span style="color: grey">(d899dc6)</span></li>
<li>vpn/strongswan/strongswanauth.ui <span style="color: grey">(5c18cc9)</span></li>
<li>vpn/strongswan/strongswanprop.ui <span style="color: grey">(3527552)</span></li>
<li>vpn/strongswan/strongswanwidget.h <span style="color: grey">(068b2eb)</span></li>
<li>vpn/strongswan/strongswanwidget.cpp <span style="color: grey">(cfb4188)</span></li>
<li>vpn/vpnc/vpnc.ui <span style="color: grey">(f305974)</span></li>
<li>vpn/vpnc/vpncauth.h <span style="color: grey">(2a0bc36)</span></li>
<li>vpn/vpnc/vpncauth.cpp <span style="color: grey">(10414aa)</span></li>
<li>vpn/vpnc/vpncauth.ui <span style="color: grey">(5c99684)</span></li>
<li>vpn/vpnc/vpncwidget.h <span style="color: grey">(0a1393b)</span></li>
<li>vpn/vpnc/vpncwidget.cpp <span style="color: grey">(6a777fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124922/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>