Review Request 123465: Add support for SSH VPN plugin

[Jan Grulich]

> On Dub. 24, 2015, 12:46 odp., Lamarque Souza wrote:
> > vpn/ssh/sshwidget.cpp, line 65
> > <https://git.reviewboard.kde.org/r/123465/diff/3/?file=362480#file362480line65>
> >
> >     Nitpick: which code style for * and & in pointers and references do you use? Most of the time you use <space>*<space> and <space>&<nospace>. If I am not mistaken the code style used in KDE is always <space>*<nospace> and <space>&<nospace>.

I know it's not an excuse, but those parts are actually copied from other VPN plugins and either me or someone else who wrote them made this mistake before, but yeah, I should properly check it and follow the coding style. I also found out that KDevelop does wrong auto-completion for functions when using KDELibs coding style, switching to Qt fixes this issue.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/#review79433
-----------------------------------------------------------


On Dub. 24, 2015, 1:14 odp., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123465/
> -----------------------------------------------------------
> 
> (Updated Dub. 24, 2015, 1:14 odp.)
> 
> 
> Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
> 
> 
> Bugs: 341070
>     http://bugs.kde.org/show_bug.cgi?id=341070
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> This patch adds support for SSH VPN plugin (according to nm-connection-editor).
> 
> 
> Diffs
> -----
> 
>   vpn/ssh/sshwidget.ui PRE-CREATION 
>   vpn/ssh/sshwidget.cpp PRE-CREATION 
>   vpn/ssh/sshwidget.h PRE-CREATION 
>   vpn/ssh/sshauth.ui PRE-CREATION 
>   vpn/ssh/sshauth.cpp PRE-CREATION 
>   vpn/ssh/sshauth.h PRE-CREATION 
>   vpn/ssh/sshadvanced.ui PRE-CREATION 
>   vpn/ssh/ssh.cpp PRE-CREATION 
>   vpn/ssh/ssh.h PRE-CREATION 
>   vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION 
>   vpn/ssh/nm-ssh-service.h PRE-CREATION 
>   vpn/ssh/Messages.sh PRE-CREATION 
>   vpn/ssh/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123465/diff/
> 
> 
> Testing
> -------
> 
> I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150424/32611628/attachment.html>