Review Request 123465: Add support for SSH VPN plugin

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123465/#review79433
-----------------------------------------------------------



vpn/ssh/sshauth.cpp (line 40)
<https://git.reviewboard.kde.org/r/123465/#comment54269>

    Yesterday you pushed a huge patch to use Qt5's connect syntax. To make things consistent you should the same for this patch.



vpn/ssh/sshwidget.cpp (line 47)
<https://git.reviewboard.kde.org/r/123465/#comment54274>

    Extra space in indentation.



vpn/ssh/sshwidget.cpp (line 65)
<https://git.reviewboard.kde.org/r/123465/#comment54275>

    Nitpick: which code style for * and & in pointers and references do you use? Most of the time you use <space>*<space> and <space>&<nospace>. If I am not mistaken the code style used in KDE is always <space>*<nospace> and <space>&<nospace>.



vpn/ssh/sshwidget.cpp (line 162)
<https://git.reviewboard.kde.org/r/123465/#comment54270>

    "type & NetworkManager::Setting::None" is always false. You should use "type == NetworkManager::Setting::None"



vpn/ssh/sshwidget.cpp (line 329)
<https://git.reviewboard.kde.org/r/123465/#comment54273>

    This line can be moved to SshSettingWidget's constructor.



vpn/ssh/sshwidget.cpp (line 353)
<https://git.reviewboard.kde.org/r/123465/#comment54271>

    The "always aks" and "not required" comments are redundant now.



vpn/ssh/sshwidget.cpp (line 364)
<https://git.reviewboard.kde.org/r/123465/#comment54272>

    You can use SettingWidget::EnumPasswordStorageType::* here too.


- Lamarque Souza


On April 22, 2015, 2:41 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123465/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 2:41 p.m.)
> 
> 
> Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
> 
> 
> Bugs: 341070
>     http://bugs.kde.org/show_bug.cgi?id=341070
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> This patch adds support for SSH VPN plugin (according to nm-connection-editor).
> 
> 
> Diffs
> -----
> 
>   libs/editor/simpleipv4addressvalidator.h 9a4e270 
>   libs/editor/simpleipv6addressvalidator.h 934dc99 
>   vpn/CMakeLists.txt 714fff0 
>   vpn/ssh/CMakeLists.txt PRE-CREATION 
>   vpn/ssh/Messages.sh PRE-CREATION 
>   vpn/ssh/nm-ssh-service.h PRE-CREATION 
>   vpn/ssh/plasmanetworkmanagement_sshui.desktop PRE-CREATION 
>   vpn/ssh/ssh.h PRE-CREATION 
>   vpn/ssh/ssh.cpp PRE-CREATION 
>   vpn/ssh/sshadvanced.ui PRE-CREATION 
>   vpn/ssh/sshauth.h PRE-CREATION 
>   vpn/ssh/sshauth.cpp PRE-CREATION 
>   vpn/ssh/sshauth.ui PRE-CREATION 
>   vpn/ssh/sshwidget.h PRE-CREATION 
>   vpn/ssh/sshwidget.cpp PRE-CREATION 
>   vpn/ssh/sshwidget.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/123465/diff/
> 
> 
> Testing
> -------
> 
> I tried to create a new SSH VPN connection in both (kde5-)nm-connection-editor and re-open it in another editor to check whether all values were stored/loaded properly.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150424/ebd05f9e/attachment.html>