Review Request 123474: Use Qt5 syntax for all signals/slots

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123474/#review79380
-----------------------------------------------------------

Ship it!


Ship It!

- Lamarque Souza


On April 23, 2015, 9:38 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123474/
> -----------------------------------------------------------
> 
> (Updated April 23, 2015, 9:38 a.m.)
> 
> 
> Review request for Network Management, Lukáš Tinkl and Lamarque Souza.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> This patch transforms old signals/slot syntax to the new one one introduced in Qt5. Not sure if this needs review, because everything compiles fine and thanks to the new syntax all issues would be spotted during compilation, but it's a quite a big patch and would be safer to have someone else to review it.
> 
> 
> Diffs
> -----
> 
>   editor/connectioneditor.cpp f2f1418 
>   kded/modemmonitor.cpp c0c4e7a 
>   kded/notification.cpp 283fc00 
>   libs/declarative/availabledevices.cpp 49b468d 
>   libs/declarative/connectionicon.h ae8cceb 
>   libs/declarative/connectionicon.cpp c654217 
>   libs/declarative/enabledconnections.cpp 8a57b50 
>   libs/declarative/networkstatus.cpp 1f830f9 
>   libs/declarative/trafficmonitor.cpp fb14654 
>   libs/editor/settings/bondwidget.cpp cb5028a 
>   libs/editor/settings/bridgewidget.cpp f0e1737 
>   libs/editor/settings/btwidget.cpp ea6f09c 
>   libs/editor/settings/cdmawidget.cpp 1030e78 
>   libs/editor/settings/connectionwidget.cpp 78ee3e5 
>   libs/editor/settings/gsmwidget.cpp 6d1b215 
>   libs/editor/settings/infinibandwidget.cpp 0425c55 
>   libs/editor/settings/ipv4widget.cpp 535a97e 
>   libs/editor/settings/ipv6widget.cpp eb6d6a7 
>   libs/editor/settings/pppoewidget.cpp 3034574 
>   libs/editor/settings/security802-1x.cpp 87f31e4 
>   libs/editor/settings/teamwidget.cpp 8254194 
>   libs/editor/settings/vlanwidget.cpp 8e704ee 
>   libs/editor/settings/wificonnectionwidget.cpp 9a9f763 
>   libs/editor/settings/wifisecurity.cpp ea56b32 
>   libs/editor/settings/wimaxwidget.cpp 8c651b8 
>   libs/editor/settings/wiredconnectionwidget.cpp 054c6ce 
>   libs/editor/settings/wiredsecurity.cpp 5dd59af 
>   libs/editor/widgets/advancedpermissionswidget.cpp e5ea269 
>   libs/editor/widgets/bssidcombobox.cpp 3168577 
>   libs/editor/widgets/hwaddrcombobox.cpp 07537e7 
>   libs/editor/widgets/ipv4routeswidget.cpp e383630 
>   libs/editor/widgets/ipv6routeswidget.cpp b4b5637 
>   libs/editor/widgets/mobileconnectionwizard.cpp 771103f 
>   libs/editor/widgets/ssidcombobox.cpp 628dc5a 
>   libs/handler.cpp 7a6d26c 
>   libs/models/networkmodel.cpp 448ac3c 
>   vpn/l2tp/l2tpauth.cpp 5172e72 
>   vpn/l2tp/l2tpwidget.cpp 2d41ea4 
>   vpn/openconnect/openconnectauth.cpp 1a186e6 
>   vpn/openconnect/openconnectwidget.cpp 8eae8ae 
>   vpn/openswan/openswanauth.cpp 4d66b26 
>   vpn/openswan/openswanwidget.cpp 689c9ac 
>   vpn/openvpn/openvpnadvancedwidget.cpp cd8785d 
>   vpn/openvpn/openvpnauth.cpp e5bef0d 
>   vpn/openvpn/openvpnwidget.cpp 94f79e6 
>   vpn/pptp/pptpauth.cpp e0d1716 
>   vpn/pptp/pptpwidget.cpp 01d18e2 
>   vpn/strongswan/strongswanauth.cpp 5856382 
>   vpn/strongswan/strongswanwidget.cpp 828e535 
>   vpn/vpnc/vpnc.h 748091c 
>   vpn/vpnc/vpnc.cpp f88d206 
> 
> Diff: https://git.reviewboard.kde.org/r/123474/diff/
> 
> 
> Testing
> -------
> 
> Everything seems to work as before.
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-networkmanager/attachments/20150423/f5aa177a/attachment.html>