<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123474/">https://git.reviewboard.kde.org/r/123474/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On April 23rd, 2015, 9:38 a.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Network Management, Lukáš Tinkl and Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated April 23, 2015, 9:38 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch transforms old signals/slot syntax to the new one one introduced in Qt5. Not sure if this needs review, because everything compiles fine and thanks to the new syntax all issues would be spotted during compilation, but it's a quite a big patch and would be safer to have someone else to review it.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Everything seems to work as before.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>editor/connectioneditor.cpp <span style="color: grey">(f2f1418)</span></li>
<li>kded/modemmonitor.cpp <span style="color: grey">(c0c4e7a)</span></li>
<li>kded/notification.cpp <span style="color: grey">(283fc00)</span></li>
<li>libs/declarative/availabledevices.cpp <span style="color: grey">(49b468d)</span></li>
<li>libs/declarative/connectionicon.h <span style="color: grey">(ae8cceb)</span></li>
<li>libs/declarative/connectionicon.cpp <span style="color: grey">(c654217)</span></li>
<li>libs/declarative/enabledconnections.cpp <span style="color: grey">(8a57b50)</span></li>
<li>libs/declarative/networkstatus.cpp <span style="color: grey">(1f830f9)</span></li>
<li>libs/declarative/trafficmonitor.cpp <span style="color: grey">(fb14654)</span></li>
<li>libs/editor/settings/bondwidget.cpp <span style="color: grey">(cb5028a)</span></li>
<li>libs/editor/settings/bridgewidget.cpp <span style="color: grey">(f0e1737)</span></li>
<li>libs/editor/settings/btwidget.cpp <span style="color: grey">(ea6f09c)</span></li>
<li>libs/editor/settings/cdmawidget.cpp <span style="color: grey">(1030e78)</span></li>
<li>libs/editor/settings/connectionwidget.cpp <span style="color: grey">(78ee3e5)</span></li>
<li>libs/editor/settings/gsmwidget.cpp <span style="color: grey">(6d1b215)</span></li>
<li>libs/editor/settings/infinibandwidget.cpp <span style="color: grey">(0425c55)</span></li>
<li>libs/editor/settings/ipv4widget.cpp <span style="color: grey">(535a97e)</span></li>
<li>libs/editor/settings/ipv6widget.cpp <span style="color: grey">(eb6d6a7)</span></li>
<li>libs/editor/settings/pppoewidget.cpp <span style="color: grey">(3034574)</span></li>
<li>libs/editor/settings/security802-1x.cpp <span style="color: grey">(87f31e4)</span></li>
<li>libs/editor/settings/teamwidget.cpp <span style="color: grey">(8254194)</span></li>
<li>libs/editor/settings/vlanwidget.cpp <span style="color: grey">(8e704ee)</span></li>
<li>libs/editor/settings/wificonnectionwidget.cpp <span style="color: grey">(9a9f763)</span></li>
<li>libs/editor/settings/wifisecurity.cpp <span style="color: grey">(ea56b32)</span></li>
<li>libs/editor/settings/wimaxwidget.cpp <span style="color: grey">(8c651b8)</span></li>
<li>libs/editor/settings/wiredconnectionwidget.cpp <span style="color: grey">(054c6ce)</span></li>
<li>libs/editor/settings/wiredsecurity.cpp <span style="color: grey">(5dd59af)</span></li>
<li>libs/editor/widgets/advancedpermissionswidget.cpp <span style="color: grey">(e5ea269)</span></li>
<li>libs/editor/widgets/bssidcombobox.cpp <span style="color: grey">(3168577)</span></li>
<li>libs/editor/widgets/hwaddrcombobox.cpp <span style="color: grey">(07537e7)</span></li>
<li>libs/editor/widgets/ipv4routeswidget.cpp <span style="color: grey">(e383630)</span></li>
<li>libs/editor/widgets/ipv6routeswidget.cpp <span style="color: grey">(b4b5637)</span></li>
<li>libs/editor/widgets/mobileconnectionwizard.cpp <span style="color: grey">(771103f)</span></li>
<li>libs/editor/widgets/ssidcombobox.cpp <span style="color: grey">(628dc5a)</span></li>
<li>libs/handler.cpp <span style="color: grey">(7a6d26c)</span></li>
<li>libs/models/networkmodel.cpp <span style="color: grey">(448ac3c)</span></li>
<li>vpn/l2tp/l2tpauth.cpp <span style="color: grey">(5172e72)</span></li>
<li>vpn/l2tp/l2tpwidget.cpp <span style="color: grey">(2d41ea4)</span></li>
<li>vpn/openconnect/openconnectauth.cpp <span style="color: grey">(1a186e6)</span></li>
<li>vpn/openconnect/openconnectwidget.cpp <span style="color: grey">(8eae8ae)</span></li>
<li>vpn/openswan/openswanauth.cpp <span style="color: grey">(4d66b26)</span></li>
<li>vpn/openswan/openswanwidget.cpp <span style="color: grey">(689c9ac)</span></li>
<li>vpn/openvpn/openvpnadvancedwidget.cpp <span style="color: grey">(cd8785d)</span></li>
<li>vpn/openvpn/openvpnauth.cpp <span style="color: grey">(e5bef0d)</span></li>
<li>vpn/openvpn/openvpnwidget.cpp <span style="color: grey">(94f79e6)</span></li>
<li>vpn/pptp/pptpauth.cpp <span style="color: grey">(e0d1716)</span></li>
<li>vpn/pptp/pptpwidget.cpp <span style="color: grey">(01d18e2)</span></li>
<li>vpn/strongswan/strongswanauth.cpp <span style="color: grey">(5856382)</span></li>
<li>vpn/strongswan/strongswanwidget.cpp <span style="color: grey">(828e535)</span></li>
<li>vpn/vpnc/vpnc.h <span style="color: grey">(748091c)</span></li>
<li>vpn/vpnc/vpnc.cpp <span style="color: grey">(f88d206)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123474/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>